fix overflow caused by manyTill implementation

[justinwoo]

Ran into this the other day with a really long string. Maybe some of the other methods might be useful to look into, but the many implementation already uses manyRec and whatnot.

I also tried to use untilM' from monad-rec-loops but on my desktop, it's just way too slow (average ~8x slower):

normal:

C:\Users\justin\Code\purescript-string-parsers [fix-manyTill-overflow ≡]> Measure-Command {pulp test}
* Building project in C:\Users\justin\Code\purescript-string-parsers
* Build successful.
* Running tests...
* Tests OK.


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 2
Milliseconds      : 102
Ticks             : 21023247
TotalDays         : 2.43324618055556E-05
TotalHours        : 0.000583979083333333
TotalMinutes      : 0.035038745
TotalSeconds      : 2.1023247
TotalMilliseconds : 2102.3247

with rec-loops untilM' p $ end *> pure true <|> pure false:

C:\Users\justin\Code\purescript-string-parsers [fix-manyTill-overflow ≡]> Measure-Command {pulp test}
* Building project in C:\Users\justin\Code\purescript-string-parsers
Compiling Text.Parsing.StringParser.Expr
Compiling Text.Parsing.StringParser.String
Compiling Test.Main
* Build successful.
* Running tests...
* Tests OK.


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 18
Milliseconds      : 694
Ticks             : 186943150
TotalDays         : 0.000216369386574074
TotalHours        : 0.00519286527777778
TotalMinutes      : 0.311571916666667
TotalSeconds      : 18.694315
TotalMilliseconds : 18694.315

[throughnothing]

Thanks for this! I had run into the same stack overflow issue recently with this module.

[paf31]

Please use replicate here 😄

[paf31]

Won't this append in reverse?

[justinwoo]

replaced my previous sick late night commit with another sick late night commit 😄

opted to reverse the list at the end like with manyRec

[paf31]

Thanks! Could you please add a test which verifies that the reversal is the right thing to do?

[justinwoo]

added as a char parse test

[paf31]

Thanks very much!