Support CodeUnit and CodePoint parsing #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinwoo
reviewed
Jul 4, 2018
| @@ -27,8 +30,9 @@ import Data.Char (toCharCode) | |||
| import Data.Either (Either(..)) | |||
| import Data.Foldable (class Foldable, foldMap, elem, notElem) | |||
| import Data.Maybe (Maybe(..)) | |||
| import Data.String (Pattern(..), drop, length, indexOf', stripPrefix) | |||
| import Data.String.CodePoints (drop, length, indexOf', stripPrefix) | |||
| import Data.String.CodeUnits (charAt, singleton) | |||
There was a problem hiding this comment.
These will probably cause issues
There was a problem hiding this comment.
Also any combinator with "Char" below should be removed/replaced in some way?
|
This sounds good, though I guess at some point there also needs to be a separate lib that can work with the actual CodePoints representation and return the final results as String |
|
What do we want to do with this? I could at least try it sometime, and I'll merge it unless someone has issues with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #43 perhaps.
/cc @justinwoo