Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

0.7 stream updates #44

Merged
merged 3 commits into from
Jul 2, 2015
Merged

0.7 stream updates #44

merged 3 commits into from
Jul 2, 2015

Conversation

ethul
Copy link
Contributor

@ethul ethul commented Jul 1, 2015

@garyb I just have to update the README and do a bit more testing. But these changes should make the streaming possible for pscBundle. For the psci task, I just wrote the .psci file. Should this push out a stream instead? We can do that, but I think it works to output the file.

I will make the remaining changes tomorrow.

ethul added 2 commits July 1, 2015 00:29
Renaming the task to `psci` and writing the result of the command to the
`.psci` file.

Note that previous commits resolved #40
Note that this is part of the updates for PureScript 0.7, which along
with previous commits resolves #38
@ethul
Copy link
Contributor Author

ethul commented Jul 1, 2015

Okay. I realized that this is not quite ready yet in terms of the stream handling. I will push more updates on this later today.

@garyb
Copy link
Member

garyb commented Jul 1, 2015

Ah, sorry I haven't had a chance to look at it yet either.

The psci task just writing the file sounds good to me, it only works if the file is called .psci anyway.

@ethul
Copy link
Contributor Author

ethul commented Jul 1, 2015

No problem at all. Stay tuned for further updates.

Migrating back to a stream implementation for the tasks to allow
conventient piping with other streams such as `gulp.dest`.
@ethul
Copy link
Contributor Author

ethul commented Jul 2, 2015

@garyb I know this is a big switch, but I've migrated back to a stream interface for the tasks. For the psc task it is not too useful to have a stream. However, for pscBundle, pscDocs, and psci, the user can now pipe the result of the task to another stream or write the result using gulp.dest.

I am still looking into issue #45, but testing with gulp the errors seem to be handled okay.

What do you think?

@garyb
Copy link
Member

garyb commented Jul 2, 2015

Looks great! Everything works perfectly on a test project I have locally 👌. We have to pipe psci to gulp.dest(".") now, but that's not a problem at all.

Thanks very much for fixing up my mess 😉

Do you want to fix #45 before releasing? I'd be happy for it to go out as-is if it's not a major problem, it would be good to have a non-RC version of the plugin out there that works with 0.7.

@ethul
Copy link
Contributor Author

ethul commented Jul 2, 2015

Thanks for taking a look and testing. Yes, we do need to pipe psci to gulp.dest, but I think the extra step is worth it for the flexibility.

And thank you for kick-starting all of these changes. #45 doesn't seem to be posing a problem in my testing so I think pushing a release as it stands now would be good. I can do a release at lunchtime today.

@garyb
Copy link
Member

garyb commented Jul 2, 2015

👍

ethul added a commit that referenced this pull request Jul 2, 2015
Merging stream refactoring for 0.7 updates.
@ethul ethul merged commit a62e8f6 into 0.7-updates-again Jul 2, 2015
@ethul ethul deleted the 0.7-stream-updates branch July 2, 2015 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants