Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Add RTS options reading from argv #57

Merged
merged 4 commits into from
Nov 28, 2015
Merged

Add RTS options reading from argv #57

merged 4 commits into from
Nov 28, 2015

Conversation

garyb
Copy link
Member

@garyb garyb commented Nov 27, 2015

@ethul how does this look?

@garyb
Copy link
Member Author

garyb commented Nov 27, 2015

Oh, I also added --require-path support in for psc-bundle and fixed a few warnings 😄

@ethul
Copy link
Contributor

ethul commented Nov 28, 2015

@garyb Looks good! Thanks for the update. Should I merge and make a release?

@garyb
Copy link
Member Author

garyb commented Nov 28, 2015

Yes please!

@ethul
Copy link
Contributor

ethul commented Nov 28, 2015

Just noticed, I think we need the requirePath value added to the list in the pscBundleOptions function. Can you please add this in to the PR?

Also, should we add any documentation about the RTS option? I was looking around and found some info on it here:
https://downloads.haskell.org/~ghc/latest/docs/html/users_guide/runtime-control.html

However, do you think there is something else we should use. Or maybe we don't need specific documentation about it. What do you think?

@garyb
Copy link
Member Author

garyb commented Nov 28, 2015

Good catch 😄

Yeah, I'm not sure how much documentation it needs - if someone has a need to use it they're probably already familiar with the RTS options. I generally have to do a lot of looking up whenever I need to figure out how to use them too, and I've only done basic things like setting the concurrency, memory limit, and debug tracing. You're right that we should mention the fact it exists at all though.

@garyb
Copy link
Member Author

garyb commented Nov 28, 2015

Ok, I've updated the fold and the docs to include the RTS info. We also had a mistake in the existing docs where require-path was listed under psc-bundle rather than psc - I've included it in both and updated the explanation for the psc-bundle usage.

@ethul
Copy link
Contributor

ethul commented Nov 28, 2015

Great! Thanks for the update and the documentation fix.

ethul added a commit that referenced this pull request Nov 28, 2015
Add RTS options reading from argv
@ethul ethul merged commit 06a81fa into master Nov 28, 2015
@ethul ethul deleted the updates branch November 28, 2015 12:48
@garyb
Copy link
Member Author

garyb commented Nov 28, 2015

Thanks for the review and release!

@ethul
Copy link
Contributor

ethul commented Nov 28, 2015

Welcome, thanks for the PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants