This repository was archived by the owner on May 1, 2020. It is now read-only.
Update to and for PureScript 0.11 #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paf31
reviewed
Apr 24, 2017
src/GulpPurescript/Options.purs
Outdated
| readPsc obj = do | ||
| src <- readSources =<< readProp srcKey obj | ||
| output <- readPropNU readString outputKey obj | ||
| noTco <- readPropNU readBoolean noTcoKey obj |
There was a problem hiding this comment.
I think some of these options are no longer available.
There was a problem hiding this comment.
Ah yeah! I didn't revise the options at all... will do now.
|
Ok, updated the compiler options and renamed the tasks to match the commands now, so it's |
|
👍 Looks good to me! |
|
@ethul can you review/merge/release when you get a chance please? No particular hurry on my behalf, but just thought I'd ping you as a reminder, since you're the official maintainer for this I think. :) |
|
Will do! Thanks for the update on this. I can do the release this weekend.
…On Thu, Apr 27, 2017 at 07:12 Gary Burgess ***@***.***> wrote:
@ethul <https://github.com/ethul> can you review/merge/release when you
get a chance please? No particular hurry on my behalf, but just thought I'd
ping you as a reminder, since you're the official maintainer for this I
think. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVYy6CPXF0jDRZc-B6OjhgWp9Zq2zIBks5r0HgygaJpZM4NG1rJ>
.
|
|
Looks great! Thanks again |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.