Skip to content
This repository was archived by the owner on Mar 25, 2021. It is now read-only.

Added GenericShowFields instances for NoConstructors and NoArguments #20

Merged
merged 5 commits into from
Dec 4, 2017

Conversation

kejace
Copy link
Contributor

@kejace kejace commented Dec 2, 2017

We needed these in order to support

derive instance genericA :: G.Generic A _

instance showGenericA :: Show A where
  show = G.genericShow

I'm not sure ["{}"] is the right thing to return here though, so I'm open to suggestions.

@paf31
Copy link
Contributor

paf31 commented Dec 3, 2017

I understand why NoArguments is needed, but not NoConstructors. Also, {} is already rendered above where genericShowFields is called, so really you should only need an empty array.

@kejace
Copy link
Contributor Author

kejace commented Dec 4, 2017

Agreed. I changed the PR accordingly.

@paf31 paf31 merged commit f7ec49d into purescript-deprecated:master Dec 4, 2017
@paf31
Copy link
Contributor

paf31 commented Dec 4, 2017

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants