This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Data.Generic.Rep.Bounded #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic implementations of Prelude.Bounded class's top and bottom.
paf31
reviewed
Jan 10, 2017
| instance genericBottomConstructor :: GenericBottom a => GenericBottom (Constructor name a) where | ||
| genericBottom' = Constructor genericBottom' | ||
|
|
||
| instance genericBottomProduct :: (GenericBottom a, GenericBottom b) => GenericBottom (Product a b) where |
There was a problem hiding this comment.
Do we want to support Bounded for product types? I think I would rather just support NoArguments.
There was a problem hiding this comment.
I have no personal objections to going the more conservative route. It's certainly more consistent with the GHC behavior. Should I modify the PR?
There was a problem hiding this comment.
Yes please. Let's keep things simple for now, and then when we add Enum deriving we'll have fewer questions 😄
|
@paf31 I've updated the branch to only support and test sum types with argument-free constructors. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic implementations of Prelude.Bounded class's top and bottom.