This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Fixes for 0.6.1 #17
Merged
Fixes for 0.6.1 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| down ctx k (Three Leaf k1 _ Leaf k2 v2 Leaf) | ||
| | k P.== k1 = fromZipper ctx (Two Leaf k2 v2 Leaf) | ||
| down ctx k (Three Leaf k1 v1 Leaf k2 _ Leaf) | ||
| | k P.== k2 = fromZipper ctx (Two Leaf k1 v1 Leaf) |
There was a problem hiding this comment.
This can be combined with the previous one right?
There was a problem hiding this comment.
Not sure I see how...
There was a problem hiding this comment.
down ctx k (Three Leaf k1 v1 Leaf k2 v2 Leaf)
| k P.== k1 = fromZipper ctx (Two Leaf k2 v2 Leaf)
| k P.== k2 = fromZipper ctx (Two Leaf k1 v1 Leaf)
|
Ouch! Will that change in future versions? PR looks good aside from my comment. |
|
@joneshf Ok, this should be good now. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@garyb @joneshf Could you please review?
To parse multiple guards, every guard needs to be equally indented, and in 0.6.1 this means that the body of the guard needs to be more indented than its expression, which breaks
purescript-listsandpurescript-maps.