Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

Added StrMap, a fast native map implementation for maps whose keys are strings. #8

Merged
merged 1 commit into from
Sep 18, 2014

Conversation

jdegoes
Copy link
Contributor

@jdegoes jdegoes commented Sep 18, 2014

@paf31 Please review.

@paf31
Copy link
Contributor

paf31 commented Sep 18, 2014

At a glance, this looks great. I'm at Strange Loop and can't really test right now, but unless anyone else sees any issue, I say merge. @garyb @joneshf

@garyb
Copy link
Member

garyb commented Sep 18, 2014

I had a quick look earlier, looks good to me. Will review properly and merge tonight if I get a chance.

garyb added a commit that referenced this pull request Sep 18, 2014
Added StrMap, a fast native map implementation for maps whose keys are strings.
@garyb garyb merged commit 3fc0d05 into purescript-deprecated:master Sep 18, 2014
@jdegoes
Copy link
Contributor Author

jdegoes commented Sep 18, 2014

Thanks! Will this automatically be available from bower now?

@garyb
Copy link
Member

garyb commented Sep 18, 2014

Yep 👍

@jdegoes jdegoes deleted the fast-string-maps branch September 18, 2014 21:23
@jdegoes
Copy link
Contributor Author

jdegoes commented Sep 18, 2014

I could not find purescript-maps on bower (using the online search), and couldn't find any version information inside the purescript-maps repo. Through what magic is this working??

@garyb
Copy link
Member

garyb commented Sep 18, 2014

Hmm, good question, not sure what's going on there. The version is done through tagging/releases: https://github.com/purescript-contrib/purescript-maps/releases/tag/v0.0.5, but not sure why it doesn't show up on the bower search.

bower search purescript-maps manages to find it. A bug with the site search maybe?

@joneshf
Copy link
Contributor

joneshf commented Sep 18, 2014

Probably has to do with it being registered to purescript/purescript-maps and it existing at purescript-contrib/purescript-maps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants