Hook creation and aliasing/newtyping #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie927
commented
Aug 14, 2019
| in | ||
| runEffectFn2 unsafeSetDisplayName name c | ||
|
|
||
| unsafeDiscardRenderEffects :: forall x y a. Render x y a -> Effect a | ||
| unsafeDiscardRenderEffects = unsafeCoerce |
There was a problem hiding this comment.
Opted to keep this an unsafeCoerce instead of exporting another unsafe function from Internal
There was a problem hiding this comment.
Also AFAIK unsafeCoerces are erased at compile-time.
There was a problem hiding this comment.
Well, probably at purs bundle time, but we use webpack :)
| newtype UseAff key a hooks | ||
| = UseAff (UseEffect key (UseState (Result a) hooks)) | ||
|
|
||
| derive instance ntUseAff :: Newtype (UseAff key a hooks) _ |
There was a problem hiding this comment.
This newtype plus the newtypeHook below results in UseAff appearing in type holes/errors rather than the inner type
| -- | may cause them to be run many times by React. | ||
| -- | You should almost always prefer `useEffect`! | ||
| unsafeRenderEffect :: forall a. Effect a -> Pure a | ||
| unsafeRenderEffect = Render |
There was a problem hiding this comment.
These two unsafe functions are named unsafe because of the effects they might produce if used incorrectly, but I'm not sure if that actually makes them unsafe..
maddie927
added a commit
that referenced
this pull request
Aug 14, 2019
Hook creation and aliasing/newtyping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the tools needed to create custom hooks, both in PS and FFI