Move shared Events stuff out of React.Basic.DOM #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddie927
changed the title
|
I don't think we should expose the constructor. If we have to expose something, it should be a smart constructor with |
|
Ah, good idea |
paf31
reviewed
Mar 28, 2018
| unsafeEventFn :: forall a b. (a -> b) -> EventFn a b | ||
| ``` | ||
|
|
||
| Unsafely create an `EventFn`. This function should be avoided. |
There was a problem hiding this comment.
Might be worth commenting briefly on why this function is dangerous (it lets SyntheticEvents leave the current scope). Otherwise, this PR looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
EventFnconstructor public (downside) but decouples the event stuff that isn't dom specific from the dom modules so they can be reused (upside).