Skip to content

Update DOM so that <form> has various 'on*' props #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2018
Merged

Update DOM so that <form> has various 'on*' props #48

merged 1 commit into from
Jul 25, 2018

Conversation

zudov
Copy link
Contributor

@zudov zudov commented Jul 24, 2018 •
edited
Loading

Fixes #45

@zudov zudov mentioned this pull request Jul 24, 2018
Closed
f-f
f-f reviewed Jul 24, 2018
View reviewed changes
src/React/Basic/DOM.purs Outdated
, onChange :: EventHandler
, onInput :: String
, onInvalid :: String
, onSubmit :: String
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be an EventHandler? (and I think also the other ones?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time to PR upstream again probably 💯

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, in the upstream there was no place to define these things AFAIK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Indeed we need a small addition to types variable in codegen.

@zudov zudov force-pushed the fix/regenerate-dom branch from a6d0b78 to 5bcb381 Compare July 24, 2018 10:05
f-f
f-f approved these changes Jul 24, 2018
View reviewed changes
Copy link

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zudov 👏

I left a small comment, but it's good by me

codegen/index.js Outdated
"onClick": "EventHandler",
"onInput": "EventHandler",
"onInvalid": "EventHandler",
"onSubmit": "EventHandler",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if Github is displaying them in a weird way or they are not aligned properly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf tabs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg, somehow they slipped in

@zudov zudov force-pushed the fix/regenerate-dom branch from 5bcb381 to 3591388 Compare July 24, 2018 10:49
@maddie927
Copy link
Member

The react-html-attributes update didn't result in any changes, correct?

@zudov
Copy link
Contributor Author

zudov commented Jul 25, 2018 •
edited
Loading

Simply rerunning codegen with react-html-attributes resulted in these changes (added on* properties to form and a). It doesn't seem like they changed anything that would require changes in codegen, only the missing properties were added.

@maddie927
Copy link
Member

Oh right, sorry. Looks good.

@maddie927 maddie927 merged commit 6eea3c3 into purescript-react:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinwoo justinwoo justinwoo left review comments

@f-f f-f f-f approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zudov @maddie927 @justinwoo @f-f