Skip to content

Provide previous props/state to didUpdate #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

maddie927
Copy link
Member

Closes #68

shouldUpdate has similar props and I've found them confusing as nothing names them as "next" or "prev", so I changed both to receive a record which at least has the property names visible. What do you think, @akheron?

Copy link
Contributor

@akheron akheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Definitely better this way.

@maddie927 maddie927 merged commit 3514a4c into master Nov 29, 2018
@maddie927 maddie927 deleted the michael/didupdate-prev-self branch November 29, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants