fixes #9 : nodeValue should return Effect (Maybe String)

[bbarker]

No description provided.

[garyb]

I'll accept this soon, just need to set enough time aside for dealing with updating dependants also, since this is a breaking change.

I'll try using version ranges for the dependants so they can be done as non-breaking bumps - in theory that should work, and is the model we'd like to use for these kind of changes, it just remains to be seen how well bower deals with it... it should be fine in theory. It's all a non-issue for spago users though.

[bbarker]

No worries - if it will take considerable time, I'd like to discuss another option that I haven't had time to create an issue for yet, but briefly this would be to potentially reduce the number of Effect-ful calls. I feel like I've seen a number of DOM methods that, according to DOM spec, do not throw exceptions - but maybe there are undocumented exceptions? Or maybe we want to treat (almost) all interactions with the DOM as effectful?

[garyb]

I think most things have to be effectful because of mutability, more so than they can throw exceptions.

[bbarker]

oh right, i forgot many operations are mutable when it seems like they shouldn't be (creating an "unrooted" node for instance) - Ill try to keep that in mind next time.

…

On Mon, May 20, 2019 at 8:27 AM Gary Burgess ***@***.***> wrote: I think most things have to be effectful because of mutability, more so than they can throw exceptions. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=AAG7XDRBQYEZYVZKQVDXOODPWKKMDA5CNFSM4HNZIW7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVYVAZY#issuecomment-493965415>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG7XDWXRYWAJNVBIARWNM3PWKKMDANCNFSM4HNZIW7A> .

-- Brandon Barker [email protected]