Use NPM dependency for PureScript compiler #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
force-pushed
the
use-ps-npm-dependency
branch
from
8b94f57 to
212d1a8
Compare
|
Are you thinking of using npm for everything in purescript-web / potentially everything outside of core? |
|
Yeah... I was thinking the other day, I don't even know if we need to use the direct dependency in core anymore, really! I think we just did that at first because it was the only way to get the compiler without building it, and then later on because we weren't in control of when the npm package was published. |
|
Yeah, that makes sense to me. |
sigma-andex
pushed a commit
to working-group-purescript-es/purescript-web-dom
that referenced
this pull request
Apr 14, 2022
Fix the retrieval of the latest compiler version tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.