-
Notifications
You must be signed in to change notification settings - Fork 23
Element.matches + Element.closest #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d033aa7
to
b0bd845
Compare
Yeah, we could perhaps move the |
I getcha. How do you, @garyb, recommend fixing this build error? * Building project in /home/runner/work/purescript-web-dom/purescript-web-dom
[1/1 DuplicateSelectiveImport] src/Web/DOM/Element.purs:57:1
57 import Web.DOM.ParentNode (ParentNode, QuerySelector)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
There is an existing import of Web.DOM.ParentNode, consider merging the import lists |
@@ -52,6 +53,8 @@ import Web.DOM.Internal.Types (Element) as Exports | |||
import Web.DOM.Internal.Types (Element, HTMLCollection, Node) | |||
import Web.DOM.NonDocumentTypeChildNode (NonDocumentTypeChildNode) | |||
import Web.DOM.ParentNode (ParentNode) | |||
import Web.DOM.ParentNode (QuerySelector) as Exports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import Web.DOM.ParentNode (QuerySelector) as Exports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't I still want to export it for convenience? (Sorry, I don't think I understand)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s also re-exported on the next line — this is the source of the duplicate error.
1296f09
to
18b5845
Compare
I added |
18b5845
to
060074a
Compare
Thanks! |
…rs-warnings Fix `HiddenConstructors` warnings
fixes #38. Copied
querySelector
-isms. It's looking like perhapsQuerySelector
doesn't make a lot of sense stuck insideParentNode
with this though. 🤔Prerequisites
purescript-web
projects. Although MDN is a great resource, it is not a suitable reference for this project.https://dom.spec.whatwg.org/#dom-element-matches
https://dom.spec.whatwg.org/#dom-element-closest
Description of the change
Add missing Element feature
Checklist: