Skip to content

create new Audio #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2020
Merged

create new Audio #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Web/HTML/HTMLAudioElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/* global Audio */
"use strict";

exports.create = function () {
return function () {
return new Audio();
};
};

exports.createWithURL = function (url) {
return function () {
return new Audio(url);
};
};
29 changes: 28 additions & 1 deletion src/Web/HTML/HTMLAudioElement.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,27 @@
module Web.HTML.HTMLAudioElement where
module Web.HTML.HTMLAudioElement
( HTMLAudioElement
, fromHTMLElement
, fromElement
, fromNode
, fromChildNode
, fromNonDocumentTypeChildNode
, fromParentNode
, fromEventTarget
, toHTMLMediaElement
, toHTMLElement
, toElement
, toNode
, toChildNode
, toNonDocumentTypeChildNode
, toParentNode
, toEventTarget
, create
, create'
) where

import Data.Maybe (Maybe)
import Effect (Effect)
import Prelude (Unit)
import Unsafe.Coerce (unsafeCoerce)
import Web.DOM (ChildNode, Element, Node, NonDocumentTypeChildNode, ParentNode)
import Web.Event.EventTarget (EventTarget)
Expand Down Expand Up @@ -57,3 +78,9 @@ toParentNode = unsafeCoerce

toEventTarget :: HTMLAudioElement -> EventTarget
toEventTarget = unsafeCoerce

foreign import create :: Unit -> Effect HTMLAudioElement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this just create :: Effect HTMLAudioElement? Why the extra Unit -> arg?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct that the Unit isn't necessary, but @toastal is following the existing pattern from the bindings from HTMLImageElement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I accepted it here, though the Unit is unnecessary. @hdgarrood would you also be open to fixing these functions so that they're just in Effect right now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... That makes more sense. Why were they originally Unit -> Effect result?

Copy link
Contributor

@thomashoneyman thomashoneyman Dec 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I don't know. 🤷‍♀️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be open to that, yes. I also don’t know why they’re like this. I generally haven’t been very involved with the web libraries, actually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... That makes more sense. Why were they originally Unit -> Effect result?

'tis a mystery to me also, even though I'm probably the one who did it 🤔

foreign import createWithURL :: String -> Effect HTMLAudioElement

create' :: String -> Effect HTMLAudioElement
create' = createWithURL