Skip to content

Fix HiddenConstructors warnings #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

kl0tl
Copy link
Contributor

@kl0tl kl0tl commented Nov 19, 2020

Exported types with hidden constructors but Generic or Newtype instances will trigger a warning in v0.14.0.

See purescript/purescript#3907.

@JordanMartinez
Copy link
Contributor

CI is failing with this warning that was converted into an error:

[1/1 UnusedExplicitImport] src/Web/HTML/Window.purs:43:1

  43  import Prelude (class Eq, class Ord, Unit, (<$>), (<<<), map)

      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  

  The import of module Prelude contains the following unused references:

  

    (<<<)

    map

  

  It could be replaced with:

  

    import Prelude (class Eq, class Ord, Unit, (<$>))

           Src   Lib   All

Warnings   0     0     0  

Errors     1     0     1  

* ERROR: Subcommand terminated with exit code 1

The command "npm run -s build" exited with 1.

@JordanMartinez
Copy link
Contributor

Otherwise, LGTM!

@kl0tl
Copy link
Contributor Author

kl0tl commented Nov 26, 2020

I removed the unused explicit imports, thank you for noticing the error Jordan !

@JordanMartinez
Copy link
Contributor

CI passes now, but I can't merge this.

@kl0tl kl0tl merged commit 942a412 into purescript-web:master Dec 5, 2020
@kl0tl kl0tl deleted the fix-hidden-constructors-warnings branch December 5, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants