Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bindings to Document.currentScript and Element.getAttribute().
Note that in an attempt to properly implement the note mentioned here regarding different DOM implementation handling for non existent attributes, the FFI code in this PR has slightly more logic than the trivial implementation. I don't know how you typically handle cases like this--if you care to target all DOM implementations, I think this is the right thing to do. If you only care to target later implementations, or if you think consumers should handle this check in purescript code, then I can make it trivial and maybe export a binding to
hasAttribute
as well? Let me know what you'd prefer here if you'd like modifications and I'm happy to oblige.