Skip to content

Remove Unit argument from create functions. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2020
Merged

Remove Unit argument from create functions. #46

merged 2 commits into from
Dec 12, 2020

Conversation

thomashoneyman
Copy link
Contributor

As discussed in #32 (comment), the create functions implemented in HTMLAudioElement and HTMLImageElement take an unnecessary unit argument. This commit updates the FFI and PureScript code to remove this argument.

cc: @garyb

@thomashoneyman thomashoneyman added the purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0 label Dec 12, 2020
@JordanMartinez JordanMartinez merged commit ed00360 into master Dec 12, 2020
@JordanMartinez JordanMartinez deleted the improve-create branch December 12, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

Assignees
No one assigned
Labels
purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomashoneyman @garyb @JordanMartinez