Skip to content

Add fromEventTarget to Window #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2021
Merged

Add fromEventTarget to Window #53

merged 3 commits into from
Mar 13, 2021

Conversation

thomashoneyman
Copy link
Contributor

@thomashoneyman thomashoneyman commented Mar 9, 2021 •
edited
Loading

Prerequisites

  • Before opening a pull request, please check the HTML standard (https://dom.spec.whatwg.org/). If it doesn't appear in this spec, it may be present in the spec for one of the other purescript-web projects. Although MDN is a great resource, it is not a suitable reference for this project.

Description of the change

Closes #28 by adding a fromEventTarget function.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@thomashoneyman thomashoneyman merged commit e057469 into master Mar 13, 2021
@thomashoneyman thomashoneyman deleted the window-fromeventtarget branch March 13, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Web.HTML.Window.fromEventTarget
2 participants
@thomashoneyman @JordanMartinez