Add page visibility state functionality #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
18
to
21
| print :: VisibilityState -> String | ||
| print = case _ of | ||
| Visible -> "loading" | ||
| Hidden -> "interactive" |
There was a problem hiding this comment.
Could you clarify where this is stated in the doc you referenced?
There was a problem hiding this comment.
Yeah, shouldn’t this be “hidden” and “visible”? Reading through the spec I didn’t see mention of these wrt visibility state.
There was a problem hiding this comment.
Ahem uhm err, I definitely didn't copy and paste this from ReadyState and forget to update these 🤦♂️
|
The other commits otherwise look fine. |
JordanMartinez
approved these changes
Sep 19, 2022
|
Thanks for taking a look and spotting that! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds type and property for page visibility state, as per https://html.spec.whatwg.org/multipage/interaction.html#page-visibility
Also did a little housekeeping while I was in there.
Checklist: