Skip to content

Add usage example to Web.Storage.Storage. Closes #5. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

Rembane
Copy link
Contributor

@Rembane Rembane commented Jan 12, 2019

No description provided.

@Rembane
Copy link
Contributor Author

Rembane commented Jan 12, 2019

It seems like I also took the liberty to add more newlines in the doc strings. The joy of resuming work on an old clone and not really paying attention.

@hdgarrood
Copy link
Contributor

Looks great, but I think it's worth adding imports, as otherwise it might not be completely clear where localStorage and window are coming from.

@Rembane
Copy link
Contributor Author

Rembane commented Jan 12, 2019

Sure thing! Imports added.

Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hdgarrood hdgarrood merged commit a6cf21e into purescript-web:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants