Skip to content

Migrate to js-promise #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Migrate to js-promise #2

merged 1 commit into from
Aug 4, 2023

Conversation

thomashoneyman
Copy link
Contributor

The web-promise library is being deprecated in favor of the node/web shared js-promise library. This PR updates webgpu to use js-promise instead of web-promise, so it can remain in the package sets after web-promise is removed.

@thomashoneyman thomashoneyman requested a review from mikesol August 4, 2023 15:58
Copy link
Collaborator

@mikesol mikesol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles, ship it!

copyExternalImageToTexture a b c d = runEffectFn4 copyExternalImageToTextureImpl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These formatting changes happened because the .tidyrc.json file specifies a max-width of 80 characters. I can revert the formatting changes if you would like.

@thomashoneyman thomashoneyman merged commit c792240 into main Aug 4, 2023
@thomashoneyman thomashoneyman deleted the js-promise branch August 4, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants