Skip to content

Add lazy versions of fromRight and fromLeft #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2020
Merged

Add lazy versions of fromRight and fromLeft #59

merged 1 commit into from
Dec 5, 2020

Conversation

JordanMartinez
Copy link
Contributor

Addresses part of #56. Docs were copied from fromMaybe' and adapted: https://pursuit.purescript.org/packages/purescript-maybe/4.0.1/docs/Data.Maybe#v:fromMaybe'

thomashoneyman
thomashoneyman approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the implementation, though I'll defer to others on whether this addition is wanted.

@JordanMartinez JordanMartinez merged commit 2f12ae8 into purescript:master Dec 5, 2020
@JordanMartinez JordanMartinez deleted the addLazyFromLR branch December 5, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanMartinez @hdgarrood @thomashoneyman