-
Notifications
You must be signed in to change notification settings - Fork 8
Switch to GitHub Actions and update installation instructions #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks good to me but we should make sure we have a plan for Pursuit uploading after a release; that's what the |
I can add the However, manual uploads may be the better bet; I believe with the new registry that publishing to Pursuit will be handled by the registry (cc: @f-f), and we've (unofficially) switched to manual uploads for the Contributors organization because a) the Pursuit upload doesn't trigger if you create the release via the UI and b) the Pursuit upload frequently fails unless you run the publish command twice. All that said, if this workflow has been working pretty consistently for the core libraries then I'll gladly preserve it. |
Those are good reasons for switching to manual uploads, so I’m on board. I do think we’ve missed a few core library releases for these reasons. |
@thomashoneyman how hard do you think it would be to take the current |
@JordanMartinez I suspect we're better off with a small bash script. In the case of the core libraries, all we really need to do is adjust the README installation instructions and build status badge, create the If, one day, we do want to update the core libraries the way we updated the contrib libraries (which I hope we do!) then we should definitely repurpose |
Another thing to be aware of if we're wanting to automate updating the CI setup across the core libraries is that some core libraries do have tests, and for those we should first run |
We could apply the |
I think the core libraries should all have package.json files, so that sounds good to me. |
With purescript/purescript-arrays#187 we have a demonstration of the same CI file working for both a library with tests and a library without tests. |
Backlinking to purescript/purescript#3962 |
This PR demonstrates switching to GitHub Actions for this repository while preserving the existing workflow from the Travis file. We can of course get fancier by caching dependencies and so on, but this presents a small enough transition that it could be applied uniformly across the core repositories. It also updates the README badge appropriately.
In addition, this updates the installation instructions to use Spago instead of Bower.