Description
Problem
- users may incorrectly use coefficients from
calcparams_desoto
withd2mutau
insinglediode
- is there a way to restrict or limit use of
d2mutau
only for coefficients derived fromcalcparams_pvsyst
? - users may not correctly account for the correct number of cells in series and the the number of junctions per cell when determining builtin voltage parameter
- the
cells_in_series
argument inbishop88
is redundant and inconsistent with the other argument with series cellsnNsVth
.
Solution
As @cwhanse suggested, replace voltage_builtin
with NsVbi
which is an output from calcparams_pvsyst
, and d2mutau
should also be passed through calcparams_pvsyst
in order to discourage users from using it with CEC or DeSoto models.
We currently pass the product
nNsVth
intosinglediode
and related functions, rather than passingn
,Ns
, andVth
separately. With the recombination current, the only placeNs
is needed separately is with the per-cellVbi
to get a moduleVbi
. I think a more consistent method would be to passNsVbi
as the argument, rather thanVbi
. That keeps all the single diode equation parameters as 'per-module' quantities, rather than a mix of per-cell and per-module.
Alternatives
Please suggest alternatives. One idea that was proposed originally was I think to lock in specific usage with the model, ie: have a separate singlediode_desoto
and singlediode_pvsyst
similar to the calcparams_*
methods. Not sure how far down this needs to go, would it also apply to bishop88
?
Additional context
this is an follow on to #504