Skip to content

improve solarposition.hour_angle and other analytical test functions #597

Closed
@wholmgren

Description

@wholmgren

Problems:

solarposition.hour_angle should have its own test in test_solarposition. Its output is tested in test_bird but that's not the right place for it.

solarposition.hour_angle is used in test_analytical_zenith and test_analytical_azimuth. That's bad practice. The success of the zenith and azimuth functions should not depend on the hour_angle function.

This situation is making it hard for me to track down an issue. There might be something wrong with solarposition.hour_angle timezone handling, but it's hard to say at the moment.

Versions:

  • pvlib.__version__: 0.6

Additional context
discovered when addressing pandas upgrade issues in #595

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions