Skip to content

Docstring cleanup: "default None", doi #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 12, 2023
Merged

Docstring cleanup: "default None", doi #1828

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
29b3aa8
Align reference
echedey-ls Jun 26, 2023
15d8107
Update irradiance.py
echedey-ls Jun 26, 2023
9c5f6b2
Remove parenthesis in types
echedey-ls Aug 6, 2023
059f32c
Remove none in type definition #1574
echedey-ls Aug 6, 2023
96a4f58
Change if none ocurrences (I)
echedey-ls Aug 6, 2023
a89addb
Change if none ocurrences (II)
echedey-ls Aug 6, 2023
e931a5d
Too long line
echedey-ls Aug 6, 2023
e9495e0
Too long line
echedey-ls Aug 6, 2023
469edc2
fix doi external links
echedey-ls Oct 28, 2023
7b3cc76
Merge branch 'main' into refactor-docstring-params-2
echedey-ls Oct 28, 2023
1bc3b12
Apply cwhanse suggestion
echedey-ls Oct 31, 2023
57f67bb
Apply cwhanse suggestion
echedey-ls Oct 31, 2023
8794a2e
Apply cwhanse suggestion
echedey-ls Oct 31, 2023
2378db1
Apply cwhanse suggestion
echedey-ls Oct 31, 2023
6171e77
Modified cwhanse suggestion
echedey-ls Oct 31, 2023
3c3779e
Merge branch 'refactor-docstring-params-2' of https://github.com/eche…
echedey-ls Oct 31, 2023
c75a662
Update modelchain.py
echedey-ls Oct 31, 2023
9c52070
Some None's missed
echedey-ls Oct 31, 2023
232156c
``none``'s, some more ``'s to variables and some other nones
echedey-ls Oct 31, 2023
b8f942b
Special ``none`` cases (please review)
echedey-ls Oct 31, 2023
f7c6c7c
Linter
echedey-ls Oct 31, 2023
ec2b176
Run more regexes
echedey-ls Oct 31, 2023
daa5e65
More Nones
echedey-ls Nov 1, 2023
8ddcd7e
Update irradiance.py
echedey-ls Nov 1, 2023
1a39119
Revert "Special ``none`` cases (please review)"
echedey-ls Nov 2, 2023
eb0806d
Apply suggestions from code review
echedey-ls Nov 2, 2023
57d61af
Update irradiance.py
echedey-ls Nov 2, 2023
69c8321
Update pvlib/irradiance.py
echedey-ls Nov 2, 2023
1f24c92
Update irradiance.py
echedey-ls Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ def get_ground_diffuse(surface_tilt, ghi, albedo=.25, surface_type=None):
overridden if surface_type is supplied.

surface_type : string, optional
If supplied, overrides ``albedo``. `surface_type` can be one of
If supplied, overrides ``albedo``. `surface_type` can be one of
'urban', 'grass', 'fresh grass', 'snow', 'fresh snow', 'asphalt',
'concrete', 'aluminum', 'copper', 'fresh steel', 'dirty steel',
'sea'.
Expand Down