-
Notifications
You must be signed in to change notification settings - Fork 1.1k
NREL mismatch loss addendum #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
9c68605
Preliminar implementation, tests, docs and gallery example
echedey-ls 7c17712
Merge branch 'main' into nrel-mismatch-loss
echedey-ls 23320db
Update versionadded
echedey-ls 47fa80d
Add example
echedey-ls 84346d2
docstring update
echedey-ls bdb9955
Update v0.11.0.rst
echedey-ls 914d009
who would have guessed it's always the linter?
echedey-ls 29f4c66
Update plot_irradiance_nonuniformity_loss.py
echedey-ls 03011d3
equation fixes
echedey-ls de1744a
RMAD properties application typo
echedey-ls 7f27c9f
does this fix the link?
echedey-ls 2cdc95f
yet another link
echedey-ls 0698839
These links will never work, I suppose
echedey-ls 7f27f1c
Move some "Notes" equations to example and rearrange things there
echedey-ls 58c05bd
give this equation it's space
echedey-ls b973959
eq rendering fixes?
echedey-ls 448b647
maths are not mathing today
echedey-ls 5768473
???
echedey-ls b1a7e4a
??? x2
echedey-ls d1b476d
??? x3
echedey-ls d037314
i feel stupid for this
echedey-ls 4ec952b
Change preprint ref to published one
echedey-ls b0cadb5
Published paper coeffs
echedey-ls 9f51b68
Lots of improvements
echedey-ls 67d3737
Linter - also missing Eq (7)
echedey-ls 10ac204
Test polynomial input
echedey-ls 9290f41
Math
echedey-ls c7b94a0
Test exception
echedey-ls 3599991
Update pvsystem.py
echedey-ls c965225
Update plot_irradiance_nonuniformity_loss.py
echedey-ls 0c15443
Add fill factor ratio
echedey-ls d141189
ª
echedey-ls 8a19a4d
Trying new things
echedey-ls c32f78a
Revert "Trying new things"
echedey-ls 5f69b6d
Update pvsystem.py
echedey-ls 4c354ea
:(
echedey-ls a2de166
:((
echedey-ls b572f45
I hope we dont miss that reference
echedey-ls 1b0565b
Update pvsystem.py
echedey-ls 87f46f0
Remove second section of the example
echedey-ls ae775ec
Minor text upgrade
echedey-ls 4c75534
Merge branch 'main' into nrel-mismatch-loss
echedey-ls 1906e20
Update pvsystem.py
echedey-ls f5863ce
Port to namespace `pvlib.bifacial`
echedey-ls a7d3f7e
Rename to ``power_mismatch_deline``, document in ``bifacial.rst``
echedey-ls 84f702f
fillfactor only for predefined models
echedey-ls 3ad18a6
Docstring rewording
echedey-ls b6c6fb2
Linter
echedey-ls 18a397f
More docs rewording
echedey-ls 1d7d86c
Merge branch 'main' into nrel-mismatch-loss
echedey-ls 8bae370
Apply suggestions from Dax
echedey-ls 75ae58b
Unneded image Dominguez_et_al_PVSC2023.png
echedey-ls b106ff8
Rename file
echedey-ls 4c78987
Fix equations
echedey-ls 56c7d2e
yup it didnt save
echedey-ls d225a6d
lintaaaaaaarrrr
echedey-ls 36f3be0
Eq 7 numbering
echedey-ls 0c99269
Revert unintended changes
echedey-ls a46245a
Adam code review
echedey-ls a4a32e0
Links?
echedey-ls 88273ba
Referencing equations manually
echedey-ls f096a0a
Polynomial links
echedey-ls 5945b74
Dont abuse math mode
echedey-ls adbcbeb
Update loss_models.py
echedey-ls 6f5c69f
I forgot
echedey-ls 770b4a5
Adam Code Review
echedey-ls 329312a
Merge branch 'main' into nrel-mismatch-loss
echedey-ls 9d0411b
Merge branch 'main' into nrel-mismatch-loss
echedey-ls a9d507f
whatsnews
echedey-ls 243de31
Update v0.11.0.rst
echedey-ls 204f8b7
Weird that some tests pass and others dont
echedey-ls a88cb4c
Update loss_models.py
echedey-ls 0136b3a
document
echedey-ls c6ca308
Update loss_models.py
echedey-ls adad0c1
Kevin's review (I)
echedey-ls 6fafcb4
Kevin's review (II)
echedey-ls 436b0e2
Kevin's review (III)
echedey-ls 7d91db6
Update v0.11.1.rst
echedey-ls b1b51bd
minor changes
echedey-ls 3991800
Forgot to update tests
echedey-ls aeaabb4
Accordingly modify model, IO, docs to unitless model
echedey-ls 9289412
Update loss_models.py
echedey-ls f025133
Update loss_models.py
echedey-ls 69a5acf
Apply suggestions from code review
echedey-ls 945d61a
Code review from Cliff
echedey-ls cecc337
Rendering issues, code review from Kevin
echedey-ls 289dbeb
Little missing newline
echedey-ls 33ef81c
RMAD func definition addendum
echedey-ls 1e8e9e4
Update v0.11.1.rst
echedey-ls 4953a3f
Merge branch 'main' into nrel-mismatch-loss
echedey-ls aa8a830
Add RMAD eq to docstring
echedey-ls 6b388d0
Cliff suggestion
echedey-ls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.