Skip to content

Split test_spectrum.py #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Aug 5, 2024

Restructure tests in line with mismatch.py restructuring. Prompted by final comments in #2136.

  • Relates to Proposal: split up mismatch.py #2125 and restructure pvlib/spectrum #2136
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini
Copy link
Contributor Author

RDaxini commented Aug 5, 2024

Should I add to the same whatsnew entry as #2136 once that is merged, or create a new entry?

add spectrl2_data function to mismatch.py
@kandersolar kandersolar added enhancement GSoC Contributions related to Google Summer of Code. labels Aug 5, 2024
@kandersolar kandersolar added this to the v0.11.1 milestone Aug 5, 2024
@kandersolar
Copy link
Member

Should I add to the same whatsnew entry as #2136 once that is merged, or create a new entry?

I'd say this PR is implicit in the whatsnew entry for #2136, so no need for another one here IMHO

@kandersolar kandersolar merged commit b2a82f1 into pvlib:main Aug 7, 2024
30 checks passed
@kandersolar
Copy link
Member

Thanks @RDaxini!

@RDaxini RDaxini deleted the restructure_test_spectrum branch August 7, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GSoC Contributions related to Google Summer of Code. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants