Skip to content

Remove broken link in pvsystem.retrieve_sam #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Nov 27, 2024

If I understood correctly, the conclusion in #2288 is to remove the links entirely rather than update the second one with https://sam.nrel.gov/photovoltaic/pv-publications.html (?)

@RDaxini RDaxini added this to the v0.11.2 milestone Nov 27, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RDaxini!

@kandersolar kandersolar merged commit f5002c7 into pvlib:main Dec 3, 2024
26 checks passed
@RDaxini RDaxini deleted the dead_links branch December 3, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in pvsystem.retrieve_sam
3 participants