Skip to content

Organize iotools reference page by data provider #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Apr 23, 2025

  • Closes iotools reference page needs some organization #2446
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

See #2446. Docs build link: https://pvlib-python--2447.org.readthedocs.build/en/2447/reference/iotools.html

@kandersolar kandersolar added this to the v0.12.1 milestone Apr 23, 2025
@kandersolar kandersolar marked this pull request as ready for review April 23, 2025 18:12
Copy link
Contributor

@RDaxini RDaxini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be value in listing the sources in alphabetical order within each category?

@AdamRJensen
Copy link
Member

AdamRJensen commented May 23, 2025

I suggest organizing by topic (Gridded irradiance data, Ground measurement irradiance data, Weather data) and secondary by public/commercial data sources.

More importantly, I think we should add a one-line description for each dataset, e.g.,

CAMS

Satellite-derived irradiance data for Europe, Africa, and Asia, and clear-sky irradiance globally.

PVGIS

Multiple gridded irradiance and weather datasets with global coverage.

NSRDB

Satellite-derived irradiance and weather data for the Americas.

Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement! Nice work @kandersolar

@AdamRJensen
Copy link
Member

I suggest also adding a link to this on the "Weather data" page in the users guide. E.g., "For an overview of available functions, see [reference to this page]"

Copy link
Contributor

@IoannisSifnaios IoannisSifnaios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @kandersolar!! I think it makes so much more sense now! Just minor things from my side.

I guess it is still a bit strange to me that they are not organized alphabetically within each category, but I don't have strong feelings about this.

:toctree: generated/

iotools.get_pvgis_tmy
iotools.read_pvgis_tmy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is more a question for @AdamRJensen: why does the description of the "read_pvgis_tmy" say "read a file downloaded from PVGIS" and does not say "read a TMY file downloaded from PVGIS"?


Accessing these APIs typically requires payment.

SolarAnywhere
Copy link
Contributor

@IoannisSifnaios IoannisSifnaios May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider adding the coverage of these datasets (in the free ones, you have a sentence saying for which part of the world they have data)

Modeled irradiance and meteorological data, available for large regions of
the world.

Public datasets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider adding to the description the timestep of each dataframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iotools reference page needs some organization
5 participants