-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ENH: infinite sheds #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ENH: infinite sheds #717
Changes from 115 commits
Commits
Show all changes
133 commits
Select commit
Hold shift + click to select a range
865cbfa
WIP: ENH: infinite sheds
mikofski 2d77d82
DOC: add infinite_sheds to api.rst, docstrings form sky_angle
mikofski 7b5def1
ENH: functions for infinite sheds
mikofski 246dd2b
ENH: clean up docstrings, add 4-quad arctan2, add api docs, more get_…
mikofski 29333dd
DOC: fix latex math, use psi_t for top, psi_b for bottom
mikofski 51fe74d
STY: don't use get_* for standard functions
mikofski 0af1fc2
ENH: create class methods to get irradiance, FIXME: front/back poa no…
mikofski 9690938
TST: add infinite_sheads test, add infinite_sheds to pvlib-api
mikofski 6d5c2cb
TST: ground illumination test
mikofski 99fdc69
TST: coerce df to float, replace div/0 with nan
mikofski 680b700
TST: set atol to 1e-6 to compare to CSV
mikofski 97d9664
TST: test for shade line
mikofski 4931446
TST: fix diffuse fraction NaN and Inf, consolidate front+back = 1 test
mikofski 7ec812b
TST: add tests for sky angle, psi_top
mikofski 7e97fcb
ENH: STY: fix stickler, ignore binary operator breaks
mikofski 4a4e22e
add fixmes for ground illumination and ground view factor
mikofski 3045928
ENH: BUG: DOC: change "ground-illumination" to "unshaded-ground-fract…
mikofski b2d0496
Merge branch 'master' into infinite_sheds
mikofski 4c2b3cd
Merge branch 'infinite_sheds' of github.com:mikofski/pvlib-python int…
mikofski 135e074
ENH: BUG: calculate angles and VF from ground between panels to sky
mikofski d32c144
ENH: BUG: remove gcr_prime from vf calc, not used
mikofski da7611b
BUG: fix view factors formulas
mikofski fde1851
STY: shorten line in test_infinite_sheds for sum of angles at z1 limit
mikofski 8247fbe
Merge branch 'master' into infinite_sheds
mikofski f9eb300
DOC: update module docstring with process from Marion, et al.
mikofski 15822ab
BUG: revert changes to ground and sky to pv surface view factors
mikofski 04a4039
ENH: integrate Fgnd-pv and Fsky-z
mikofski c87148a
Merge branch 'master' into infinite_sheds
mikofski 5453527
Merge branch 'master' into infinite_sheds
mikofski 5798343
Merge branch 'master' into infinite_sheds
mikofski 9ee9486
Merge branch 'infinite_sheds' of github.com:mikofski/pvlib-python int…
mikofski d4cdd20
Merge branch 'master' into infinite_sheds
mikofski ae0c651
Merge branch 'master' into infinite_sheds
mikofski 0f08cb7
fix references
mikofski 0559e57
update infinite sheds
mikofski 6db7104
remove discretized angles for fgndsky
mikofski b211037
don't discretize z
mikofski d137f04
clarify what next, prev mean
mikofski 6a583cf
clarify what z0 and z1 limits mean
mikofski 089a355
clean up outputs for get_irradiance
mikofski 1671e7e
consolidate solar projection tests
mikofski 6d5776b
use fraction of pvsurface fx
mikofski 2a38dfd
Merge branch 'master' into infinite_sheds
mikofski 2f3ffcf
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
cwhanse dddae59
be quiet stickler
cwhanse 71a6fa0
TODO inserts, docstring edits
cwhanse 2a174dc
re-organize
cwhanse cd0d114
create test files, move two functions to utils
cwhanse 8f11255
adjust test paths
cwhanse d2c1448
fix testing
cwhanse 144489f
adjustments to sky_angle_tangent
cwhanse a55f587
adjustments to get tests to run
cwhanse b6ee09a
move shade_line to shading.shaded_fraction
cwhanse 517c303
remove shade_line from infinite_sheds
cwhanse c2fdc56
remove functions that have moved to utils, shading
cwhanse 5aef380
move several functions to private
cwhanse 60ed926
move more functions to private
cwhanse 0d088db
update test_utils.py
cwhanse e689377
linting
cwhanse 3e45cd4
tilt to surface_tilt, docstring work
cwhanse 80cd517
consolidate some functions, docstring work
cwhanse 9744776
sky diffuse view factors
cwhanse 923a014
finish editing get_irradiance and supporting functions
cwhanse e62d4a6
rework public functions
cwhanse cdc4153
formatting
cwhanse d1d4005
remove old test file
cwhanse 56eb655
add tests for sky_angle functions, remove diffuse_ratio
cwhanse b6c60b1
more tests, fix error in _sky_angle
cwhanse 66f0350
more tests and docstring work
cwhanse aae4d12
stickler
cwhanse 76a2066
space, merge upstream
cwhanse e87cc03
remove old test file, test fixes
cwhanse 2ac6639
test fixes
cwhanse b556c55
remove axis from linspace usage
cwhanse a7ee923
documentation
cwhanse 682f23c
docstrings
cwhanse 4b035da
height = 0 and surface_tilt = 0 cases
cwhanse 64a7f95
vectorize _vf_ground_sky
cwhanse 336ad62
overhaul ground to sky view factors, add function to utils
cwhanse ea5ea20
lint, handle floats
cwhanse c5a9d61
improve test fixture, remove unused
cwhanse 6156dca
loop over rotations in _vf_ground_sky_integ, test get_irradiance_poa
cwhanse c574262
more tests
cwhanse c581c88
lint
cwhanse b0ba9f5
complete coverage
cwhanse 6127c4f
progress on testing get_irradiance
cwhanse 186d670
more testing
cwhanse e25a113
whoops
cwhanse 466cde7
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
cwhanse 460714a
merge upstream
cwhanse f0eb172
remove local test hack
cwhanse 3dbed5f
correction to unshaded_ground_fraction
cwhanse 296b137
move pvfactors tests
cwhanse a9e139a
additional testing
cwhanse 992d428
add max_zenith to unshaded_ground_fraction
cwhanse 0b81a92
docstring work
cwhanse 2bc3a10
use shading function, extend shading.shaded_fraction
cwhanse 49958df
documentation
cwhanse 224e5b4
clarifications, consistent argument order
cwhanse d71c9cd
fix errors
cwhanse b084c34
use numeric instead of array-like
cwhanse 3ccd302
docstring sanding
cwhanse 3e16964
more docstring work, reorder arguments for consistency
cwhanse 8adf64e
edits from review
cwhanse 337262c
fix tests
cwhanse e5fb113
fix test
cwhanse b316d3b
remove max_rows from public
cwhanse 371c407
move shaded_fraction from shading.py to infinite_sheds private
cwhanse f161dce
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
cwhanse 679731a
move shading_fraction
cwhanse a90a045
repair test, stickler
cwhanse 6c1f12c
remove axis_azimuth
cwhanse eff490c
redo tests without axis_azimuth, few corrections
cwhanse eb6daa7
trailing spaces
cwhanse 525078f
behind the array criteria, return names
cwhanse 1564a40
changes from review
cwhanse aaa7262
diffuse fraction when ghi is 0
cwhanse 5814085
clean up
cwhanse d64ea79
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
cwhanse 01a5fc1
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
cwhanse 5b1357b
Apply suggestions from code review
cwhanse 5d1b778
changes solar_zenith, solar_azimuth names
cwhanse 03c49c0
Update pvlib/bifacial/infinite_sheds.py
cwhanse 764f807
DOI directive in infinite_sheds.get_irradiance
mikofski da34555
Merge branch 'master' into infinite_sheds
mikofski 5688240
change back to solar_zenith, solar_azimuth
cwhanse 80fb2b6
Merge branch 'infinite_sheds' of https://github.com/mikofski/pvlib-py…
cwhanse 60fa642
rename in test_utils
cwhanse 8bc1d1d
OrderedDict to dict
cwhanse 87d472a
create bifacial.rst
cwhanse 2c9d4c9
Update docs/sphinx/source/user_guide/bifacial.rst
cwhanse 1a7c33c
Apply suggestions from code review
cwhanse b2c19a7
remove OrderedDict
cwhanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
""" | ||
The ``bifacial`` module contains functions to model irradiance for bifacial | ||
modules. | ||
|
||
""" | ||
from pvlib._deprecation import deprecated | ||
from pvlib.bifacial import pvfactors, infinite_sheds, utils # noqa: F401 | ||
kandersolar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
pvfactors_timeseries = deprecated( | ||
since='0.9', | ||
kandersolar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
name='pvlib.bifacial.pvfactors_timeseries', | ||
alternative='pvlib.bifacial.pvfactors.pvfactors_timeseries' | ||
)(pvfactors.pvfactors_timeseries) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.