FIX correct license, package name and authors/email #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jorisvandenbossche @jreback does this look right/better? |
|
@hayd You now included the pandas licence. I have to say, I don't know much about licenses, but shouldn't there also be a license that is mentioning pandas-datareader? |
|
This looks fine to me (but I don't know anything about licences). Is this good to go? @jorisvandenbossche @hayd @jreback |
|
It could probably be modified in future to something like pandas-data-reader follows the pandas license, for now this is an obvious improvement. |
hayd
added a commit
that referenced
this pull request
Mar 26, 2015
FIX correct license, package name and authors/email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3 the name to pandas-datareader.
Corrects the license, url and contact info etc. for setup.py.