Add slc
option to Chain.get_draws
and get_stats
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
slc
kwarg to the method signatures.In a follow-up PR the implementations---particularly the
ClickHouseChain._get_rows
method---can be updated to make use of theslc
information to select the data more efficiently (#50).I added tests that assert that the
slc
functions in the same way as NumPy slicing the result manually.Closes #47