Skip to content

Pass slice to get draws/stats in to_inferencedata #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Pass slice to get draws/stats in to_inferencedata #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions mcbackend/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,17 +223,17 @@ def to_inferencedata(self, *, equalize_chain_lengths: bool = True, **kwargs) ->
posterior = collections.defaultdict(list)
sample_stats = collections.defaultdict(list)
for c, chain in enumerate(chains):
# NOTE: Replace the truncation with a ranged fetch once issue #47 is resolved.
# Create a slice to use when fetching the variables
if min_clen is None:
# Every retrieved array is shortened to the previously determined chain length.
# This is needed for database backends which may get inserts inbetween.
clen = chain_lengths[chain.cid]
# Needed for backends which may get inserts inbetween our get_draws/get_stats calls.
slc = slice(0, chain_lengths[chain.cid])
else:
clen = min_clen
slc = slice(0, min_clen)

# Obtain a mask by which draws can be split into warmup/posterior
if "tune" in chain.sample_stats:
tune = chain.get_stats("tune")[:clen].astype(bool)
tune = chain.get_stats("tune", slc).astype(bool)
else:
if c == 0:
_log.warning(
Expand All @@ -243,12 +243,12 @@ def to_inferencedata(self, *, equalize_chain_lengths: bool = True, **kwargs) ->

# Split all variables draws into warmup/posterior
for var in variables:
draws = chain.get_draws(var.name)[:clen]
draws = chain.get_draws(var.name, slc)
warmup_posterior[var.name].append(draws[tune])
posterior[var.name].append(draws[~tune])
# Same for sample stats
for svar in self.meta.sample_stats:
stats = chain.get_stats(svar.name)[:clen]
stats = chain.get_stats(svar.name, slc)
warmup_sample_stats[svar.name].append(stats[tune])
sample_stats[svar.name].append(stats[~tune])

Expand Down