Skip to content

Standardize test messages to use the permissible constraints (i.e. the thing being asserted) #6158

Closed
@ccaprani

Description

@ccaprani

Following on from the discussion here pymc-devs/pymc-extras#84 (comment) with @ricardoV94, in many places the test message is written in the opposite direction to the check it looks like, e.g. Gumbel, Logistic, Normal, HalfNormal, Beta; e.g.

check_parameters(res, 0 < beta, msg="beta > 0")

Others are written in the same direction, e.g. TruncatedNormal, Wald, Kumaraswamy and so on.

logp = check_parameters(
                logp,
                at.le(lower, upper),
                msg="lower_bound <= upper_bound",
            )

Messages should be standardized to use the permissable constraints; i.e. written in the same direction.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions