Skip to content

Theano-PyMC compatibility updates #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 16, 2020

Conversation

brandonwillard
Copy link
Contributor

This PR fixes some compatibility issues introduced by recent changes in Theano-PyMC.

@brandonwillard brandonwillard changed the title Theano pymc updates Theano-PyMC compatibility updates Nov 10, 2020
@brandonwillard brandonwillard marked this pull request as draft November 11, 2020 04:38
@brandonwillard
Copy link
Contributor Author

brandonwillard commented Nov 11, 2020

FYI: These tests won't pass until we cut the next release of Theano-PyMC, since the updates this PR targets aren't released yet.

@Sayam753
Copy link
Member

Hi @brandonwillard

I was running test suite locally on this PR with theano-pymc@master. And pymc3/tests/test_ode.py::test_logp_scalar_ode failed with AttributeError: 'DifferentialEquation' object has no attribute '_get_test_value'.

So, looking upon the PR pymc-devs/Theano-PyMC#112, these lines need to be refactored as well.

https://github.com/pymc-devs/pymc3/blob/0b0797011c0c8023743aaf94dd0016e001191c17/pymc3/ode/ode.py#L165-L167

I think this has to deal with new theano.gof.get_test_value function.

@brandonwillard brandonwillard force-pushed the theano-pymc-updates branch 2 times, most recently from 101af8d to a2efd82 Compare November 15, 2020 20:51
@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #4218 (3ea99ac) into master (0b07970) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4218   +/-   ##
=======================================
  Coverage   88.94%   88.95%           
=======================================
  Files          92       92           
  Lines       14800    14806    +6     
=======================================
+ Hits        13164    13170    +6     
  Misses       1636     1636           
Impacted Files Coverage Δ
pymc3/distributions/dist_math.py 91.82% <100.00%> (+0.03%) ⬆️
pymc3/distributions/multivariate.py 81.12% <100.00%> (-0.08%) ⬇️
pymc3/model.py 89.36% <100.00%> (+0.02%) ⬆️
pymc3/ode/ode.py 93.81% <100.00%> (+0.06%) ⬆️
pymc3/tests/helpers.py 60.34% <100.00%> (+3.74%) ⬆️

@brandonwillard brandonwillard marked this pull request as ready for review November 15, 2020 23:53
@twiecki twiecki merged commit 83b91d8 into pymc-devs:master Nov 16, 2020
@twiecki
Copy link
Member

twiecki commented Nov 16, 2020

Thanks @brandonwillard and @Sayam753!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import error: cannot import name 'until' from 'theano.scan_module'
3 participants