-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Theano-PyMC compatibility updates #4218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI: These tests won't pass until we cut the next release of Theano-PyMC, since the updates this PR targets aren't released yet. |
I was running test suite locally on this PR with theano-pymc@master. And So, looking upon the PR pymc-devs/Theano-PyMC#112, these lines need to be refactored as well. I think this has to deal with new |
101af8d
to
a2efd82
Compare
a2efd82
to
c6865c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #4218 +/- ##
=======================================
Coverage 88.94% 88.95%
=======================================
Files 92 92
Lines 14800 14806 +6
=======================================
+ Hits 13164 13170 +6
Misses 1636 1636
|
Thanks @brandonwillard and @Sayam753! |
This PR fixes some compatibility issues introduced by recent changes in Theano-PyMC.