Skip to content

update pre-commit hooks versions #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Nov 16, 2020

Update pre-commit hook versions numbers

nbqa 0.4.1 has handles code inside of in-line magics - this only affects one file here - and simplifies configuration a bit

the new pyupgrade version 2.7.4 doesn't seem to affect any code here, but it's still probably better to stay up-to-date

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MarcoGorelli MarcoGorelli changed the title ⬆️ update pre-commit hooks update pre-commit hooks Nov 16, 2020
@MarcoGorelli MarcoGorelli changed the title update pre-commit hooks update pre-commit hooks versions Nov 16, 2020
@@ -718,7 +718,9 @@
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the trailing backslashes are necessary to retain validity of the in-line magic


Reply via ReviewNB

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #4228 (4ac868d) into master (83b91d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4228   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files          92       92           
  Lines       14806    14806           
=======================================
  Hits        13170    13170           
  Misses       1636     1636           

Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @MarcoGorelli !

@AlexAndorra AlexAndorra merged commit cb87715 into pymc-devs:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants