Move travis CI to GitHubActions #4254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Nov 25, 2020
Comment on lines
-25
to
-27
| - pycodestyle>=2.3 | ||
| - pyflakes>=1.5 | ||
| - pylint>=1.7 |
There was a problem hiding this comment.
remove these (and other formatters/linters) as they're run via pre-commit
AlexAndorra
reviewed
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #4254 +/- ##
==========================================
- Coverage 88.18% 88.11% -0.08%
==========================================
Files 89 87 -2
Lines 14371 14243 -128
==========================================
- Hits 12673 12550 -123
+ Misses 1698 1693 -5
|
|
As travis broken anyway let's merge this and see if it works and fix it in prod ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to upload to codecov, but for now this seems to run the same tests travis did (except pylint, which in #4242 I've moved over to pre-commit so it provides faster feedback to devs)
closes #4251
EDIT
passes codecov now
still to do: arviz compatibility job. I can't tell what the binder job does, I don't see it run in travis jobs from old pRs