Fixup all non-theano non-notebook docs warnings, replace dead link #4300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Dec 5, 2020
Comment on lines
+1
to
+4
| :orphan: | ||
|
|
||
| .. | ||
| _href from docs/source/index.rst |
There was a problem hiding this comment.
otherwise Sphinx throws the "not included in any toctree!" warning
MarcoGorelli
commented
Dec 5, 2020
Comment on lines
-26
to
+33
| weights = pm.Normal('weights', mu=0, sigma=1) | ||
| noise = pm.Gamma('noise', alpha=2, beta=1) | ||
| y_observed = pm.Normal('y_observed', | ||
| mu=X @ weights, | ||
| sigma=noise, | ||
| observed=y) | ||
| weights = pm.Normal("weights", mu=0, sigma=1) | ||
| noise = pm.Gamma("noise", alpha=2, beta=1) | ||
| y_observed = pm.Normal( | ||
| "y_observed", | ||
| mu=X @ weights, | ||
| sigma=noise, | ||
| observed=y, | ||
| ) |
There was a problem hiding this comment.
this doesn't actually throw a warning or anything, the indentation just looks a bit strange to me
MarcoGorelli
commented
Dec 5, 2020
Comment on lines
-102
to
+107
| <img src="https://lh5.googleusercontent.com/R1T8ZXbMi4vSO0JlnLQMkEQNvd2ncBb23OmHOsmw-t_oEOF6jJlfWuJoOK0MMmECSDymhUdfTS2yoMgkR2TY-xIiBTHCpeuYjzXqD3xhZ-MuIhs2ARcJ=w1280"> | ||
| <img src="https://lh5.googleusercontent.com/Ms2ssellxl7cM6OEL_kpiKRojcj2E4ZaUWDXOa8zEwi-v9orJGYuhjczbwFSDJNsEb_ruiwtCJONNjoo7T1c7qorZm3LsAnroMAm4S5WzNT_PVqWz9aE=w1280"> |
There was a problem hiding this comment.
replaces dead link
Codecov Report
@@ Coverage Diff @@
## master #4300 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 88 88
Lines 14355 14355
=======================================
Hits 12588 12588
Misses 1767 1767 |
michaelosthege
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some warnings coming from using automodule on theano functions, and from the notebooks' docstrings, but this at least fixes those given from PyMC3's own rst files.
Also, the old link to "Doing Bayesian Analysis" seems like it was down