Align advertised Metropolis stats_dtypes with changes from 1e7d91f
#5882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5882 +/- ##
==========================================
- Coverage 89.48% 89.48% -0.01%
==========================================
Files 73 73
Lines 13225 13225
==========================================
- Hits 11835 11834 -1
- Misses 1390 1391 +1
|
|
Should we be testing this somewhere here? |
ricardoV94
approved these changes
Jun 12, 2022
We should refactor the whole sampler stats API and test should be part of that.. |
Can you open an issue for remembering to test this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pymc-devs/mcbackend#27 I tried to upgrade to
4.0.0but the CI failed.The reason for the failure is an incorrect
stats_dtypes["accepted"]which was not updated with the changes in 1e7d91f.