-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add ZeroSumNormal
distribution
#6121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
6260c84
Use None as default value for zerosum_axes
AlexAndorra af96016
Add tests for ZSN
AlexAndorra 71e5651
Reorder dispatched functions
AlexAndorra 3cadb26
Test pylint
AlexAndorra a66c586
Ignore type check on normalize_axis_tuple
AlexAndorra e3be495
Disable mypy on import of normalize_axis_tuple
AlexAndorra 759de36
Remove base class in tests
AlexAndorra a5a1e45
Use pytest parametrize
AlexAndorra c9eea6e
Add pm.draw to tests
AlexAndorra 0582d7c
Test moment
AlexAndorra 0bdcdd7
Add change size test
AlexAndorra 854ef4c
Move ZSN to multivariate.py
AlexAndorra fd3aefa
Move ZSN tests to test_multivariate.py
AlexAndorra e94e4f1
Add check if zerosum_axes is iterable in dist method
AlexAndorra dec4a9f
Improve test_zsn_change_dist_size
AlexAndorra f7a55c5
Improve docstrings
AlexAndorra da6eaab
Refactor get_steps to work with multivariate support shapes
AlexAndorra a5ed1f0
Refactor ZSN dist and logp for rightmost zerosum_axes
AlexAndorra 126e76b
Start writing __new__ method
AlexAndorra 3a8d898
Handle single output and fix transform
AlexAndorra 4c52737
Fix indexing of at.stack in get_support_shape
AlexAndorra 7e4ed0a
Fix examples in ZSN docstrings
AlexAndorra 44b5b91
Refactor test_zsn_dims_shape
AlexAndorra 99dbb38
Refactor test_zsn_fail_axis
AlexAndorra e3dc1d4
Refactor test_zsn_change_dist_size
AlexAndorra 09f0d91
Simplify test_zsn_dims_shape
AlexAndorra cf5b384
Refactor test_zsn_dims_shape
AlexAndorra 3e86a3e
Fix get_support_shape
AlexAndorra ce68f02
Test support_shape handling
AlexAndorra 09d849c
Merge branch 'main' into add-zerosumnormal
AlexAndorra b50909e
Remove TODO list comment
AlexAndorra c204131
Merge branch 'add-zerosumnormal' of https://github.com/pymc-devs/pymc…
AlexAndorra 7ba1d0f
Add test of ZSN variance
AlexAndorra 5ee950a
Remove unused imports
AlexAndorra 95ffc94
Merge branch 'main' into add-zerosumnormal
AlexAndorra 13a54e6
Replace get_steps by get_support_shape_1d in timeseries.py
AlexAndorra ca655bc
Split dims and shape test
AlexAndorra 9d419ef
Fix test_get_support_shape_1d
AlexAndorra 85da56c
Add test_get_support_shape
AlexAndorra f363118
Add ZSN logp test
AlexAndorra 64eca5c
Fix test_inconsistent_steps_and_shape
AlexAndorra c5e76c9
Integrate review comments
AlexAndorra 08c9df0
Solve freaking pre-commit issues
AlexAndorra c120f7e
Put assert_zerosum_axes at top of test class
AlexAndorra ba5f3a1
Improve error message of get_support_shape
AlexAndorra 48dafe9
Nicer format for ZSN logp test
AlexAndorra 6612a24
Increase tolerance for test_zsn_variance
AlexAndorra 6b07a2a
Add ZSN to docs
AlexAndorra 135ed47
Refactor ZSN docs
AlexAndorra cba0187
Better latex in ZSN docs
AlexAndorra 566f308
Add ZeroSumTransform to docs
AlexAndorra 5954e65
Remove mention of default value in ZS transform docs
AlexAndorra 3e72922
Update pymc/distributions/transforms.py
ricardoV94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ Multivariate | |
|
||
MvNormal | ||
MvStudentT | ||
ZeroSumNormal | ||
Dirichlet | ||
Multinomial | ||
DirichletMultinomial | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,7 @@ Specific Transform Classes | |
LogExpM1 | ||
Ordered | ||
SumTo1 | ||
ZeroSumTransform | ||
|
||
|
||
Transform Composition Classes | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.