Skip to content

Fix warn_treedepth looking at the wrong stat #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

michaelosthege
Copy link
Member

Fixes a bug in warn_treedepth that was introduced in code refactoring PR #6192.

Closes #6587

Checklist

Bugfixes

  • Fixes incorrect warnings about reaching max treedepth.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #6591 (8297c5b) into main (cf6d4ce) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6591      +/-   ##
==========================================
+ Coverage   92.03%   92.04%   +0.01%     
==========================================
  Files          92       92              
  Lines       15535    15535              
==========================================
+ Hits        14297    14299       +2     
+ Misses       1238     1236       -2     
Impacted Files Coverage Δ
pymc/distributions/discrete.py 99.22% <ø> (ø)
pymc/model.py 89.52% <ø> (ø)
pymc/stats/convergence.py 94.73% <100.00%> (+4.38%) ⬆️

... and 1 file with indirect coverage changes

@michaelosthege michaelosthege marked this pull request as ready for review March 11, 2023 23:04
@ricardoV94
Copy link
Member

Can we add a parametrize to whatever test checks this warning, that it is not issued when it shouldn't? Maybe just use the model from the original issue

@michaelosthege michaelosthege merged commit ff8a4c7 into pymc-devs:main Mar 12, 2023
@michaelosthege michaelosthege deleted the fix-6587 branch March 12, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_treedepth warning in pm.sample()?
3 participants