Skip to content

Fix changed files filters in tests workflow #6659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Apr 8, 2023

The paths filter action syntax is different than the githubs action one, so that pymc/**.py only matches python files in the first subdirectory, whereas the github one matched files in any subdirectories.

We need to use pymc/**/*.py instead.

The tests in #6658 were not triggered because of this


📚 Documentation preview 📚: https://pymc--6659.org.readthedocs.build/en/6659/

Introduced in 433703ab0156c88de4eb3b180ea85ec21dd3e3fb
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #6659 (7cd51a8) into main (0d7413e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6659      +/-   ##
==========================================
- Coverage   91.99%   91.97%   -0.02%     
==========================================
  Files          94       94              
  Lines       15942    15942              
==========================================
- Hits        14666    14663       -3     
- Misses       1276     1279       +3     

see 1 file with indirect coverage changes

@ricardoV94 ricardoV94 requested a review from twiecki April 8, 2023 06:51
@ricardoV94 ricardoV94 added bug Github CI/CD no releasenotes Skipped in automatic release notes generation labels Apr 8, 2023
@ricardoV94 ricardoV94 merged commit 5d68bf3 into pymc-devs:main Apr 8, 2023
@ricardoV94 ricardoV94 deleted the fix_add_all_workflow branch June 6, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Github CI/CD no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants