Adding description to Gumbel Distribution #6810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6810 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 96 96
Lines 16369 16369
=======================================
Hits 15065 15065
Misses 1304 1304
|
amyoshino
changed the title
5 tasks
Co-authored-by: larryshamalama <[email protected]>
|
@larryshamalama I have made all changes I believe we needed to address your review. Thanks again for your guidance and let me know if we are missing anything. |
larryshamalama
approved these changes
Aug 13, 2023
There was a problem hiding this comment.
Looks good, thanks @amyoshino for this PR and thanks for your patience 😅
|
@larryshamalama thank you again for your guidance!! I am happy to be able to contribute 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Closes PR "The Gumbel Distribution is incorrectly described" #6478
It looks like it is only missing the corrections pointed out in the PR #6478.
I have modified helios1014's PR to address comments and revisions made by michaelosthege and OriolAbril.
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6810.org.readthedocs.build/en/6810/