Skip to content

Recognize alternative form of sigmoid in logprob inference #6978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Nov 1, 2023


📚 Documentation preview 📚: https://pymc--6978.org.readthedocs.build/en/6978/

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #6978 (50d1144) into main (714b4a0) will decrease coverage by 3.46%.
The diff coverage is 100.00%.

❗ Current head 50d1144 differs from pull request most recent head dadd981. Consider uploading reports for the commit dadd981 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6978      +/-   ##
==========================================
- Coverage   92.18%   88.72%   -3.46%     
==========================================
  Files         100      100              
  Lines       16894    16898       +4     
==========================================
- Hits        15573    14993     -580     
- Misses       1321     1905     +584     
Files Coverage Δ
pymc/logprob/rewriting.py 90.10% <100.00%> (+0.10%) ⬆️

... and 24 files with indirect coverage changes

Copy link
Contributor

@LukeLB LukeLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me! Just need to remove that empty dictionary

@ricardoV94 ricardoV94 force-pushed the recognize_sigmoid_logprob branch from 50d1144 to dadd981 Compare November 3, 2023 12:05
@ricardoV94 ricardoV94 merged commit ec4407d into pymc-devs:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants