-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Bump PyTensor dependency and drop support for python 3.9 #7227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you miss the python_requires
line in setup.py
?
There is also python_version
in mypy.ini
and tool.ruff.target-version
in pyproject.toml
but this will make pre-commit
unhappy so I am happy to clean these up in another PR
1db0e42
to
b0faf03
Compare
Thanks, updated it. |
@Armavica do you want to update the mypy / pre-commit version? Feel free to push to this branch |
Seems like something is broken :D |
Yes, I don't really understand what… I tried a few of the tests that fail here and they work on my machine, and I don't really understand this mamba error on pre-commit either |
Are you running with the newer Pytensor? |
Ok I can reproduce now 🤦♂️ |
I'll try and fix next week, probably my fault anyway :) |
We should switch to setup-micromamba. I did that recently but I forget where. |
here probably? #7213 |
Ah ya, thanks! That's the one! |
c247bdd
to
4915607
Compare
This is the error:
What is restricted to 3.9? |
Ah I think we just need to tweak the python version in the pre-commit workflow |
2241d1f
to
32bb0d6
Compare
Tests are passing |
Description
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7227.org.readthedocs.build/en/7227/