Handle compute_map=None in Scan
#1435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1435 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 211 211
Lines 49751 49752 +1
Branches 8817 8818 +1
=======================================
+ Hits 40857 40859 +2
Misses 6714 6714
+ Partials 2180 2179 -1
🚀 New features to boost your workflow:
|
This was referenced May 31, 2025
ricardoV94
reviewed
Jun 1, 2025
pytensor/scan/op.py
Outdated
| @@ -1500,6 +1500,10 @@ def make_thunk(self, node, storage_map, compute_map, no_recycling, impl=None): | |||
| node_input_storage = [storage_map[r] for r in node.inputs] | |||
| node_output_storage = [storage_map[r] for r in node.outputs] | |||
|
|
|||
| # HACK: Here to handle Blockwise Scans | |||
There was a problem hiding this comment.
It's not a hack, compute map for inner graphs is useless.
Instead of creating a compute_map make an if/else below where rval is returned and return an rval that doesn't try to assign to compute_map if it was None
There was a problem hiding this comment.
@ricardoV94 is this change alright?
ricardoV94
approved these changes
Jun 2, 2025
ricardoV94
changed the title
compute_map=None in Scan
|
Thanks @zaxtax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should also fix some regressions in the recent release. Add a
Nonecheck forcompute_mapinmake_thunkRelated Issue
Closes #1425
Type of change